make -C bpf checkpatch
为什么 Cilium 这么严格?
这是 Cilium 自己的 CUSTOM rule,不是 upstream kernel:
- commit subject 强制 ≤ 75 chars
- 不接受“接近就算了”
- 超 1 个字符都 fail CI
这是为了:
- GitHub PR 列表可读性
git log --oneline- stable backport 工具
root@debian:~/f/cilium optional-disable-sip-verify ✔ 16m ⍉
▶ make -C bpf checkpatch
make: Entering directory '/root/f/cilium/bpf'
docker container run --rm \
--workdir /workspace \
--volume /root/f/cilium/bpf/..:/workspace \
--user "0:0" \
-e GITHUB_REF= -e GITHUB_REPOSITORY= -e GITHUB_TOKEN= \
--entrypoint /bin/bash quay.io/cilium/cilium-checkpatch:1755701578-b97bd7a@sha256:f1332fa6edbbd40882a59ceae4a7843a4095bd62288363740e84b82708624c50 /checkpatch/checkpatch.sh -- --ignore MACRO_ARG_REUSE
Unable to find image 'quay.io/cilium/cilium-checkpatch:1755701578-b97bd7a@sha256:f1332fa6edbbd40882a59ceae4a7843a4095bd62288363740e84b82708624c50' locally
quay.io/cilium/cilium-checkpatch@sha256:f1332fa6edbbd40882a59ceae4a7843a4095bd62288363740e84b82708624c50: Pulling from cilium/cilium-checkpatch
9824c27679d3: Pull complete
5f45cf4c01d7: Pull complete
aa9730314510: Pull complete
5a1ac6f40119: Pull complete
b3daf4d43f3e: Pull complete
Digest: sha256:f1332fa6edbbd40882a59ceae4a7843a4095bd62288363740e84b82708624c50
Status: Downloaded newer image for quay.io/cilium/cilium-checkpatch@sha256:f1332fa6edbbd40882a59ceae4a7843a4095bd62288363740e84b82708624c50
Retrieved 3 commits on top of ref origin/main
=========================================================
[1/3] Running on 01d7f9456b6c542a10b613f17a3fae2c19738350
feat(endpoint): improve source IP verification annotation handling and regeneration logic
=========================================================
"[PATCH] feat(endpoint): improve source IP verification annotation" has no obvious style problems and is ready for submission.
NOTE: Ignored message types: BIT_MACRO C99_COMMENT_TOLERANCE COMMIT_LOG_LONG_LINE COMMIT_MESSAGE COMPLEX_MACRO CONSTANT_CONVERSION CONST_STRUCT EMAIL_SUBJECT FILE_PATH_CHANGES FROM_SIGN_OFF_MISMATCH GIT_COMMIT_ID JIFFIES_COMPARISON LEADING_SPACE LONG_LINE_COMMENT MACRO_ARG_REUSE MACRO_WITH_FLOW_CONTROL MULTISTATEMENT_MACRO_USE_DO_WHILE NOT_UNIFIED_DIFF PRINTK_WITHOUT_KERN_LEVEL TRAILING_SEMICOLON TRAILING_STATEMENTS VOLATILE
ERROR:CUSTOM: Please avoid long commit subjects (max: 75, found: 89)
=========================================================
[2/3] Running on 0e1e874a726684979a81675b4852163425c5fa90
feat(annotations): enhance source IP verification annotation handling
=========================================================
"[PATCH] feat(annotations): enhance source IP verification annotation" has no obvious style problems and is ready for submission.
NOTE: Ignored message types: BIT_MACRO C99_COMMENT_TOLERANCE COMMIT_LOG_LONG_LINE COMMIT_MESSAGE COMPLEX_MACRO CONSTANT_CONVERSION CONST_STRUCT EMAIL_SUBJECT FILE_PATH_CHANGES FROM_SIGN_OFF_MISMATCH GIT_COMMIT_ID JIFFIES_COMPARISON LEADING_SPACE LONG_LINE_COMMENT MACRO_ARG_REUSE MACRO_WITH_FLOW_CONTROL MULTISTATEMENT_MACRO_USE_DO_WHILE NOT_UNIFIED_DIFF PRINTK_WITHOUT_KERN_LEVEL TRAILING_SEMICOLON TRAILING_STATEMENTS VOLATILE
=========================================================
[3/3] Running on 3466db7510cac963260a5ffcaf9ac80e2df36e23
feat(annotations): allow use pod annotation to disable source ip verification
=========================================================
"[PATCH] feat(annotations): allow use pod annotation to disable" has no obvious style problems and is ready for submission.
NOTE: Ignored message types: BIT_MACRO C99_COMMENT_TOLERANCE COMMIT_LOG_LONG_LINE COMMIT_MESSAGE COMPLEX_MACRO CONSTANT_CONVERSION CONST_STRUCT EMAIL_SUBJECT FILE_PATH_CHANGES FROM_SIGN_OFF_MISMATCH GIT_COMMIT_ID JIFFIES_COMPARISON LEADING_SPACE LONG_LINE_COMMENT MACRO_ARG_REUSE MACRO_WITH_FLOW_CONTROL MULTISTATEMENT_MACRO_USE_DO_WHILE NOT_UNIFIED_DIFF PRINTK_WITHOUT_KERN_LEVEL TRAILING_SEMICOLON TRAILING_STATEMENTS VOLATILE
ERROR:CUSTOM: Please avoid long commit subjects (max: 75, found: 78)
All done
make: *** [Makefile.bpf:64: checkpatch] Error 1
make: Leaving directory '/root/f/cilium/bpf'
(v.v)
root@debian:~/f/cilium optional-disable-sip-verify ✔